Skip to content

#686 #696 Remove dir options and improve docs#701

Closed
andrewtavis wants to merge 2 commits into
mainfrom
686-696-remove-dir-options-update-docs
Closed

#686 #696 Remove dir options and improve docs#701
andrewtavis wants to merge 2 commits into
mainfrom
686-696-remove-dir-options-update-docs

Conversation

@andrewtavis

Copy link
Copy Markdown
Member

Contributor checklist


Description

This PR will remove the ability to define output and other directories from Scribe-Data to dramatically simplify the code. We'll also go through and do a check of the docs. This PR also includes restructuring of the CLI code into subdirectories to make the functionality more understandable and modular.

Related issue

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member Author

Closing in favor of #702 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ability to change output directories from Scribe-Data Scribe-Data markdown and rst documentation check

1 participant