Skip to content

fix(ui): decode room id from URL and encode it when writing back #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmattheis merged 1 commit into from
Sep 27, 2026
Merged

fix(ui): decode room id from URL and encode it when writing back #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ui/src/useRoomID.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,7 @@ export const getRoomFromURL = (): string | undefined => getFromURL('room');
export const getFromURL = (
key: string,
search: string = window.location.search
): string | undefined =>
search
.slice(1)
.split('&')
.find((param) => param.startsWith(`${key}=`))
?.split('=')[1];
): string | undefined => new URLSearchParams(search).get(key) ?? undefined;

export const useRoomID = (): [string | undefined, (v?: string) => void] => {
const [state, setState] = React.useState<string | undefined>(() => getRoomFromURL());
Expand All @@ -25,7 +20,12 @@ export const useRoomID = (): [string | undefined, (v?: string) => void] => {
(id) =>
setState((oldId?: string) => {
if (oldId !== id) {
window.history.pushState({roomId: id}, '', id ? `?room=${id}` : '?');
const params = new URLSearchParams();
if (id) {
params.set('room', id);
}
const query = params.toString();
window.history.pushState({roomId: id}, '', query ? `?${query}` : '?');
}
return id;
}),
Expand Down
Loading