Repository navigation
Keep namespace wildcards in canonical() of combined selectors and :is() - #204
Merged
Merged
Conversation
CombinedSelector, Matching and SpecificityAdjustment dropped a redundant
universal selector from their subselector with lstrip("*"), which also
stripped the "*" of a "*|" namespace wildcard: "foo *|bar" became
"foo |bar", turning "any namespace" into "no namespace". Only strip a
"*" followed by "#", ".", "[" or ":", as Selector and Negation do.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 3 3
Lines 987 987
Branches 162 162
=======================================
Hits 985 985
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Can you please look into missing coverage? |
Contributor
Author
|
the missed line was the strip in |
AdrianAtZyte
approved these changes
Oct 19, 2026
wRAR
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canonical()of a combined selector,:is()and:where()strips a leading*from its argument withlstrip("*"), which also eats the*of a*|namespace wildcard:parse('foo *|bar')[0].canonical()returnsfoo |bar, so "any namespace" turns into "no namespace" and re-parsing it translates todescendant::barinstead ofdescendant::*[local-name() = 'bar'], matching different elements.Selector.canonical()andNegation.canonical()already only strip a*followed by#,.,[or:; this uses the same check at the threelstripsites, with round-trip cases added totest_css_export.