Skip to content

Number every build by the commits on main - #81

Merged
scooper4711 merged 2 commits into
mainfrom
chore/build-number-from-git
Nov 16, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
chore/build-number-from-git

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Summary

  • The Mac build's BUILD_NUMBER now defaults to the number of commits on main (scripts/version.sh build), and VERSION to the newest release tag, instead of BUILD_NUMBER falling back to the version.
  • The iPad app gets the same numbers: the scheme's build pre-action writes ios/Version.xcconfig from scripts/version.sh (as Field Guide, Mapsmith and Pawn Shop already do), and the app target no longer hard-codes CURRENT_PROJECT_VERSION = 1.
  • The CI test job and the release job check out the full history: version.sh refuses a shallow clone, whose count would go backwards.
  • The spec now says where the build number comes from.

The updater compares CFBundleShortVersionString, so the build number change doesn't affect updates.

Test plan

  • Built the Mac app from this branch: the bundle carries the branch's commit count as its build number
  • Built the iPad app for the simulator: CFBundleVersion is the commit count and CFBundleShortVersionString the latest tag
  • shellcheck on the changed scripts
  • CI green

The build number is now the number of commits on main, read by
scripts/version.sh, so every build carries one and it only grows.
CI and release checkouts fetch the full history, which the count
needs.
@scooper4711
scooper4711 merged commit 148c7f0 into main Nov 16, 2026
2 checks passed
@scooper4711
scooper4711 deleted the chore/build-number-from-git branch November 16, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant