Repository navigation
Number every build by the commits on main - #81
Merged
Merged
Conversation
The build number is now the number of commits on main, read by scripts/version.sh, so every build carries one and it only grows. CI and release checkouts fetch the full history, which the count needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILD_NUMBERnow defaults to the number of commits onmain(scripts/version.sh build), andVERSIONto the newest release tag, instead ofBUILD_NUMBERfalling back to the version.ios/Version.xcconfigfromscripts/version.sh(as Field Guide, Mapsmith and Pawn Shop already do), and the app target no longer hard-codesCURRENT_PROJECT_VERSION = 1.version.shrefuses a shallow clone, whose count would go backwards.The updater compares
CFBundleShortVersionString, so the build number change doesn't affect updates.Test plan
CFBundleVersionis the commit count andCFBundleShortVersionStringthe latest tag