Repository navigation
Download the title another app asks for on the iPad - #80
Merged
Merged
Conversation
When another app asks for a title that is not on the iPad, the app now downloads it instead of only showing the library. PadHandoffHandler handles the download link and LibraryWindow routes requests to it. RequestLinkUITests covers the flow in the simulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the iPad, when another Tableside Toolkit app asked for a title that is not on disk, Scrollkeeper only brought itself forward and ignored the request.
This change adds
PadHandoffHandler, which handles open and download requests on the iPad. It checks the app key, shows the title, downloads it when needed, and shows an alert when it cannot. It sends nothing back to the requesting app. Other links, such as a barescrollkeeper://or an index request, still only bring the app forward. The spec indocs/specs/app-handoffis updated to match (2.9).Tests:
swiftlint --strictis clean and the coverage gate passes (97.3% lines, 94.3% regions).RequestLinkUITestspassed 3/3 on the iPad simulator.Not included: an unrelated local change to
ios/Scrollkeeper.xcodeproj/.../Package.resolved, which is not committed.