Repository navigation
fix: Show the About screen from the iPad's menu bar - #78
Merged
Merged
Conversation
On the iPad the menu bar's About Scrollkeeper opened an empty window. It now opens a window with the Community Use Policy notice, links and acknowledgments that Settings shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the iPad, the menu bar's About Scrollkeeper opened an empty window, without the Community Use Policy notice.
Change
AboutViewandAcknowledgmentsViewthat Settings shows.handlesExternalEvents(matching: [])), so request links still reach the library window.Testing
make lintpasses.