Skip to content

fix: Register the scrollkeeper link in the iPad app - #77

Merged
scooper4711 merged 2 commits into
mainfrom
fix/ipad-url-scheme
Nov 16, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
fix/ipad-url-scheme

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Problem

On the iPad, Mapsmith's Download in Scrollkeeper button (and the cloud button beside a map that isn't downloaded) did nothing. Mapsmith opens scrollkeeper:// to bring Scrollkeeper forward, but only the Mac build declared that URL scheme; the iOS target's generated Info.plist had none.

Fix

  • ios/Info.plist declares the scrollkeeper scheme, and the app's Debug and Release configurations merge it into the generated Info.plist (INFOPLIST_FILE).
  • The iPad app still handles no requests (app-handoff 2.9): the link only brings the app forward, in the window it has.
  • The app-handoff spec says so.

Testing

  • New RequestLinkUITests opens the link from the home screen and checks that the app comes forward in its existing window; it passes in the iPad simulator.
  • make lint and make test pass (323 tests).
  • Not run: the rest of the iPad UI suite, and a physical iPad.

Mapsmith on the iPad opens scrollkeeper:// to bring Scrollkeeper forward for a map that isn't downloaded, but the iOS target declared no URL scheme, so the button did nothing.
@scooper4711
scooper4711 merged commit a0532e0 into main Nov 16, 2026
2 checks passed
@scooper4711
scooper4711 deleted the fix/ipad-url-scheme branch November 16, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant