Repository navigation
fix: Register the scrollkeeper link in the iPad app - #77
Merged
Merged
Conversation
Mapsmith on the iPad opens scrollkeeper:// to bring Scrollkeeper forward for a map that isn't downloaded, but the iOS target declared no URL scheme, so the button did nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the iPad, Mapsmith's Download in Scrollkeeper button (and the cloud button beside a map that isn't downloaded) did nothing. Mapsmith opens
scrollkeeper://to bring Scrollkeeper forward, but only the Mac build declared that URL scheme; the iOS target's generated Info.plist had none.Fix
ios/Info.plistdeclares thescrollkeeperscheme, and the app's Debug and Release configurations merge it into the generated Info.plist (INFOPLIST_FILE).Testing
RequestLinkUITestsopens the link from the home screen and checks that the app comes forward in its existing window; it passes in the iPad simulator.make lintandmake testpass (323 tests).