Repository navigation
fix: Keep the iPhone on the sidebar after Back from the library - #76
Merged
Merged
Conversation
CI's Xcode 26.6 (Swift 6.3.3) crashed in IRGen on a method-reference setter in SidebarView. Use a closure instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one piece of TestFlight feedback so far: on an iPhone, Back from the library showed the sidebar for a moment, then bounced back to All Titles.
On an iPhone the split view collapses into a stack. Back empties the sidebar's selection, and the sidebar turned an empty selection into All Titles; with a selection again, the split view pushed the library back. Now, in the one-column layout, an emptied selection shows the sidebar and keeps the scope. The Mac and the iPad still fall back to All Titles, as before.
Tested: new UI test
testBackFromTheLibraryStaysOnTheSidebar(failed before the fix on the bounce, passes now) with the other phone UI tests on an iPhone 16 simulator; iPad UI tests; lint; 323 unit tests; Mac build. Not tested on a real iPhone.Closes #75