Skip to content

fix: Keep the iPhone on the sidebar after Back from the library - #76

Merged
scooper4711 merged 2 commits into
mainfrom
fix/phone-back-to-sidebar
Nov 15, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
fix/phone-back-to-sidebar

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Fixes the one piece of TestFlight feedback so far: on an iPhone, Back from the library showed the sidebar for a moment, then bounced back to All Titles.

On an iPhone the split view collapses into a stack. Back empties the sidebar's selection, and the sidebar turned an empty selection into All Titles; with a selection again, the split view pushed the library back. Now, in the one-column layout, an emptied selection shows the sidebar and keeps the scope. The Mac and the iPad still fall back to All Titles, as before.

Tested: new UI test testBackFromTheLibraryStaysOnTheSidebar (failed before the fix on the bounce, passes now) with the other phone UI tests on an iPhone 16 simulator; iPad UI tests; lint; 323 unit tests; Mac build. Not tested on a real iPhone.

Closes #75

CI's Xcode 26.6 (Swift 6.3.3) crashed in IRGen on a method-reference setter in SidebarView. Use a closure instead.
@scooper4711
scooper4711 merged commit d06afd8 into main Nov 15, 2026
2 checks passed
@scooper4711
scooper4711 deleted the fix/phone-back-to-sidebar branch November 15, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPhone: Back from the library bounces to All Titles instead of showing the sidebar

1 participant