Skip to content

fix: Make the iPad UI tests hold up on a slow simulator - #73

Merged
scooper4711 merged 1 commit into
mainfrom
fix/flaky-ipad-ui-tests
Nov 12, 2026
Merged

scooper4711 merged 1 commit into
mainfrom
fix/flaky-ipad-ui-tests

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Summary

The iPad UI tests failed on #72 and again on main after its merge, in a different test each time; a re-run of the main job passed without changes. Both failures are timing on a slow runner, not the Save As fix.

  • "the running download is not listed": the demo download takes eight seconds and could be over before the test looked for it. The tests that need a running download now launch with -demoDownloadSeconds 300, a new launch argument for demo mode. Without it downloads take eight seconds as before.
  • "library did not load": titleRow now allows 90 seconds instead of 30, which also has to cover the library loading. It also drags the list by a third of the screen and holds it, instead of swiping: a swipe lets the list coast, and a row the list coasts past is dropped again before it is looked for.

Notes

  • The cause of "library did not load" is not established: CI keeps no result bundle to look at. The longer wait and the drag address the two ways it can happen that I can see.

Testing

  • Lint, unit tests and coverage pass on macOS.
  • The iPad UI tests pass locally. Neither failure reproduced locally before the change either, so CI on this PR is the real check.

Two runs on CI failed in different tests. A demo download of eight
seconds could be over before the test looked for it, so those tests now
ask for long downloads with -demoDownloadSeconds. Finding a title's row
now drags the list without letting it coast past the row, and allows
longer for the library to load.
@scooper4711
scooper4711 merged commit ff61cb0 into main Nov 12, 2026
2 checks passed
@scooper4711
scooper4711 deleted the fix/flaky-ipad-ui-tests branch November 12, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant