Repository navigation
fix: Make the iPad UI tests hold up on a slow simulator - #73
Merged
Merged
Conversation
Two runs on CI failed in different tests. A demo download of eight seconds could be over before the test looked for it, so those tests now ask for long downloads with -demoDownloadSeconds. Finding a title's row now drags the list without letting it coast past the row, and allows longer for the library to load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iPad UI tests failed on #72 and again on
mainafter its merge, in a different test each time; a re-run of themainjob passed without changes. Both failures are timing on a slow runner, not the Save As fix.-demoDownloadSeconds 300, a new launch argument for demo mode. Without it downloads take eight seconds as before.titleRownow allows 90 seconds instead of 30, which also has to cover the library loading. It also drags the list by a third of the screen and holds it, instead of swiping: a swipe lets the list coast, and a row the list coasts past is dropped again before it is looked for.Notes
Testing