Repository navigation
feat: Add the About screen with Paizo's notices - #38
Merged
Merged
Conversation
Mapsmith had no About screen, and on the iPad the menu bar's About item opened an empty window. The Mac's app menu and the iPad's menu bar now show tabletop-kit's About with the Community Use Policy notice, and the iPad and iPhone have About in the toolbar. Needs tabletop-kit 1.3.0. The Open from Scrollkeeper layout test also accepts No Maps from Scrollkeeper Yet, which it shows when the simulator has Scrollkeeper installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mapsmith had no About screen anywhere, so Paizo's Community Use Policy notice wasn't shown. On the iPad, the menu bar's About Mapsmith opened an empty window.
Change
AboutInfo.mapsmith: the app's description and contact link; tabletop-kit adds the notices.AboutWindow.AboutSheet.Testing
AboutUITestsopens About from the toolbar and finds the notice; it passes with theLayoutUITestsin the iPad simulator.make lintandswift testpass.Needs tabletop-kit 1.3.0 (scooper4711/tabletop-kit#47):
Package.swiftrequires it, so CI resolves only once it's released; runswift package update tabletop-kitthen to refreshPackage.resolved.