Skip to content

feat: Add the About screen with Paizo's notices - #38

Merged
scooper4711 merged 2 commits into
mainfrom
feat/about-screen
Nov 16, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
feat/about-screen

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Problem

Mapsmith had no About screen anywhere, so Paizo's Community Use Policy notice wasn't shown. On the iPad, the menu bar's About Mapsmith opened an empty window.

Change

  • AboutInfo.mapsmith: the app's description and contact link; tabletop-kit adds the notices.
  • Mac: About Mapsmith in the app menu shows the About panel with the notices.
  • iPad: About Mapsmith in the menu bar opens tabletop-kit's AboutWindow.
  • iPad and iPhone: an About toolbar button opens AboutSheet.
  • The Open from Scrollkeeper layout test now also accepts No Maps from Scrollkeeper Yet, which it shows when the simulator has Scrollkeeper installed.
  • Spec: ipad-app R6 and design notes.

Testing

  • New AboutUITests opens About from the toolbar and finds the notice; it passes with the LayoutUITests in the iPad simulator.
  • make lint and swift test pass.
  • The menu bar item can't be reached from XCUITest; please check it by hand.

Needs tabletop-kit 1.3.0 (scooper4711/tabletop-kit#47): Package.swift requires it, so CI resolves only once it's released; run swift package update tabletop-kit then to refresh Package.resolved.

Mapsmith had no About screen, and on the iPad the menu bar's About item opened an empty window. The Mac's app menu and the iPad's menu bar now show tabletop-kit's About with the Community Use Policy notice, and the iPad and iPhone have About in the toolbar. Needs tabletop-kit 1.3.0.

The Open from Scrollkeeper layout test also accepts No Maps from Scrollkeeper Yet, which it shows when the simulator has Scrollkeeper installed.
@scooper4711
scooper4711 merged commit 50518e2 into main Nov 16, 2026
3 of 4 checks passed
@scooper4711
scooper4711 deleted the feat/about-screen branch November 16, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant