Repository navigation
fix: Refuse a scale that needs more than ten pages across or down - #29
Merged
Merged
Conversation
A mistyped or misdetected scale (for example 1 pixel per square, or a hex map) produced a plan of hundreds of thousands of pages, and SwiftUI aborted drawing the page labels. TilePlanner.plan now returns nil above maximumPagesPerSide (10) in both orientations, checked before any page is laid out. The preview says "Too Many Pages" and the inspector shows a warning. This applies to typed and detected scales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mistyped or misdetected scale (for example 1 pixel per square, or a hex map) produced a plan of hundreds of thousands of pages, and SwiftUI aborted drawing the page labels.
TilePlanner.plannow returns nil abovemaximumPagesPerSide(10) in both orientations, checked before any page is laid out. The preview says "Too Many Pages" and the inspector shows a warning. This applies to typed and detected scales.Four new planner tests. 107 tests pass; SwiftLint clean.