Let' use shared_cluster based on share_cluster.json variable and update PyTest#293
Merged
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
Author
|
[test-openshift-pytest] |
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed Triggered by Workflow Run |
Testing Farm results
|
phracek
changed the title
in the rest containers. Inspiration is taken from mariadb-container and mysql-container. Let's use conftest.py instead of a lot of duplication in alone PyTest files Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
Author
|
The OpenShift PyTests have more verbose logs like we have in the other containers. [test-openshift-pytest] |
Member
Author
|
@frenzymadness Can you please have a look at it? It should be a super simply. Hopefully I have learned a lot from the previous containers reviews ;) |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
One small nitpick and there is also a typo in the first commit message - there is "s" missing in "Let's".
But it looks good to me otherwise.
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
Author
|
[test-openshift-pytest] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's decide is shared_cluster is used by variable in file
/root/shared_cluster.jsondelivered during the instance preparation.
Update also PyTest suite like we do in mariadb-container or mysql-container or the rest.