Repository navigation
Build contribute and finalize specs from sciline split - #10
Merged
Merged
Conversation
sciline ADR 0003 dropped Aggregation in favour of split, which derives the stages of one or more nested loops. A package now builds CONTRIBUTE and FINALIZE from the stages of one split. Mention that a FINALIZE may read several sums, the SANS case that ruled out a single Aggregation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sciline ADR 0003 (scipp/sciline#245) no longer has
Aggregation;splitderives the stages of nested loops instead. Nothing in essapps usedAggregation(onlysciline.Stage, inpipeline.py), so this changes docs only.The README said a package derives CONTRIBUTE, PARTS_SUM, and FINALIZE from its sciline
Aggregation. It now says the package builds CONTRIBUTE and FINALIZE from the stages of onesplit, cut at the keys PARTS_SUM sums. It also says that a FINALIZE may read several sums (sample and background runs). That is the SANS case that ruled out a singleAggregationin sciline, and essapps handles it without one.🤖 Generated with Claude Code