Repository navigation
do not raise exceptions when filters could not be applied - #10
Merged
Merged
Conversation
- when, e.g., some column is not available with the data, then skip the filter - when a filter could not be applied, treat this as if no instance survived the filter; it will then be deactivated because it is empty
svigerske
force-pushed
the
ignore-failing-filter
branch
from
October 22, 2026 13:57
f724455 to
53582ff
Compare
Merged
Member
Author
|
For context: We add runs with SoPlex to Rubberband. The usual evaluations (that have SCIP in mind) failed because the data for some filters were not available for SoPlex runs, e.g., number of continuous variables, or dual LP solver iterations (we only have iterations). This may be useful when using Rubberband with other solvers, too. |
Collaborator
|
This looks good to me. |
stephenjmaher
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When, e.g., some column is not available with the data, then skip the filter.