Skip to content

[ENH] update gha#1341

Merged
arnaudbore merged 1 commit into
scilus:masterfrom
arnaudbore:update_gha
Jun 22, 2026
Merged

[ENH] update gha#1341
arnaudbore merged 1 commit into
scilus:masterfrom
arnaudbore:update_gha

Conversation

@arnaudbore

Copy link
Copy Markdown
Contributor

Quick description

Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (b2bf4ac) to head (c20e3b2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   72.60%   72.59%   -0.02%     
==========================================
  Files         301      301              
  Lines       26276    26276              
  Branches     3699     3699              
==========================================
- Hits        19078    19075       -3     
  Misses       5648     5648              
- Partials     1550     1553       +3     
Flag Coverage Δ
smoketests 69.75% <ø> (-0.02%) ⬇️
unittests 14.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.32% <ø> (-0.03%) ⬇️
Library 69.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore arnaudbore requested a review from AlexVCaron June 22, 2026 20:07

@AlexVCaron AlexVCaron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks clean ! The only contentious point would've been the artifacts actions versions, which are well aligned.

Eventually, I'd suggest reassembling the base, ml and tutorial tests under the same workflow using a matrix, to have them part of the same coverage report. But it's a non-issue.

LGTM 🚀

@arnaudbore arnaudbore added this pull request to the merge queue Jun 22, 2026
Merged via the queue into scilus:master with commit 4f2ec20 Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants