Repository navigation
ci: fix test startup with pytest 9.2 - #1821
Merged
ariostas merged 2 commits intoNov 6, 2026
Merged
Conversation
With filterwarnings = error, pytest 9.2 stops at startup in two jobs: - anyio < 4.15's pytest plugin imports the deprecated _pytest.python.CallSpec2. The ROOT jobs get anyio from conda-forge as a dependency of ROOT, so ask for anyio>=4.15 there. - pytest-asyncio, installed with pytest-pyodide, warns that asyncio_default_fixture_loop_scope is unset. Set it on the command line of the Pyodide job; it can't go in pyproject.toml because --strict-config rejects it in the jobs that don't have pytest-asyncio. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/ignore-pytest-9.2-warnings
branch
from
November 5, 2026 16:27
ccd4740 to
5622632
Compare
ariostas
changed the title
github-actions
Bot
added
type/ci
ariostas
changed the title
conda-forge's anyio 4.15+ requires Python >= 3.11, so the ROOT 6.32 job, on Python 3.10, couldn't be solved. No test uses anyio's pytest plugin, so don't load it, which works with any anyio version, or none. Assisted-by: Claude Code:claude-opus-5-5
ariostas
marked this pull request as ready for review
November 5, 2026 17:21
ianna
approved these changes
Nov 6, 2026
ariostas
added a commit
to sumitsaraswat362/uproot5
that referenced
this pull request
Nov 10, 2026
Compute the per-tag cluster offsets with bincount/cumsum instead of a per-cluster Python loop, skip padding before the first cluster, and document that switch columns are CPU-only (CuPy has no structured dtypes). Drop the pytest<9.2.0 pin, which scikit-hep#1821 made unnecessary. In the tests, look up the switch column by type, add an end-to-end test with None entries, and cover padding, absent tag 0, and single-cluster cases. Assisted-by: Claude Code:claude-opus-5-5
ariostas
added a commit
that referenced
this pull request
Nov 10, 2026
…1818) * fix: offset variant switch column indices across clusters * test: add unit coverage for variant cluster combining edge cases * ci: pin pytest below 9.2.0 to resolve plugin incompatibilities * ci: re-trigger test matrix * perf(rntuple): use running accumulator for variant switch cluster offsets * fix(rntuple): vectorize variant switch index offsets and tighten tests Compute the per-tag cluster offsets with bincount/cumsum instead of a per-cluster Python loop, skip padding before the first cluster, and document that switch columns are CPU-only (CuPy has no structured dtypes). Drop the pytest<9.2.0 pin, which #1821 made unnecessary. In the tests, look up the switch column by type, add an end-to-end test with None entries, and cover padding, absent tag 0, and single-cluster cases. Assisted-by: Claude Code:claude-opus-5-5 --------- Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.2.0 makes two CI jobs fail at startup, before any test runs, because of
filterwarnings = error. This fixes the causes instead of ignoring the warnings:_pytest.python.CallSpec2(PytestRemovedIn10Warning). This job gets anyio 4.14.2 from conda-forge as a dependency of ROOT, and conda-forge's anyio 4.15+ requires Python >= 3.11, while the job runs on 3.10. No test uses anyio's pytest plugin, soaddoptsnow has-p no:anyio. That works with any anyio version, or none.asyncio_default_fixture_loop_scopeis unset (PytestDeprecationWarning). The job now sets it tofunction, the future default, with-oon its pytest command lines. It can't go inpyproject.toml: with--strict-config, every job that doesn't have pytest-asyncio would fail on the unknown option.This unblocks other PRs, e.g. #1820. #1814 ignores these warnings in
pyproject.tomlinstead; I'll drop that from #1814 once this is merged.AI assistance: this change was made with Claude Code.