Name Nod loops, and run Nod's headless calls by quoted path - #618
Merged
Merged
Conversation
TitleSuggestionClient returned nil for Nod, so a blank-titled Nod loop stayed NewNode. SummaryModelWriter named graphcode-nod bare, which is not on the login shell's PATH, so every Nod summary rewrite failed silently. Both now run the runtime NodRuntimeLocator finds, like the session launch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
The login-shell launcher typed the executable unquoted, so a Nod runtime inside an app whose path has a space was split at the space and never ran. Bare CLI names are still typed exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loops on the Nod backend were never named: a blank-titled Nod loop stayed "NewNode".
TitleSuggestionClientreturnednilfor.nod, a placeholder from when Nod was added. It now runsgraphcode-nod -pfrom the pathNodRuntimeLocatorfinds, like the session launch. With no runtime it still declines.SummaryModelWriternamedgraphcode-nodbare. It is not on the login shell's PATH, so every Nod rewrite failed silently. It now uses the located path.ZmxSessionLauncher.loginShellInvocationtyped the executable unquoted, so a runtime inside an app whose path has a space was split and never ran. Paths that need it are now single-quoted; bare CLI names (claude,copilot, …) are byte-identical to before.Evidence
RED: xcodebuild test -only-testing NodLaunchArgumentTests with main's three source files -> exit 65; titleRequestsRunTheBundledRuntimeByPath, summaryRewritesRunTheBundledRuntimeByPath and aRuntimePathWithASpaceSurvivesTheLoginShell fail
GREEN: xcodebuild test -only-testing NodLaunchArgumentTests on this branch -> exit 0, all suite tests pass including the 4 new ones
REGRESSION: xcodebuild test (full graphcode scheme) -> 2232 tests, 1 failure in MessageDeliveryTests.aSessionWhoseTaskEndedIsNeverTypedInto, which fails identically on main's sources; make check -> exit 0; graphcoded and graphcode-cli schemes -> BUILD SUCCEEDED
Manual:
graphcode-nod -pfrom the installed app returnedLoginPageTimeoutFix(exit 0). In zsh,exec <path with space> "$@"fails with "no such file or directory: …/Graph"; the quoted form runs.