Recognise the Copilot CLI's login in Nod's setup - #610
Merged
Merged
Conversation
…en where the runtime reads it Beta1's setup screen only knew GitHub's device flow, which needs a GraphCode OAuth client id the build does not carry, so it failed with "This build has no GitHub sign-in configured" on every Mac, including ones already signed in to the Copilot CLI that NodRuntime falls back to. - A Copilot CLI login (Keychain service copilot-cli) counts as signed in, shown as "Using your Copilot CLI sign-in" with nothing to sign out of. - Without a client id the screen says to run copilot login, with Check again, instead of offering a device flow that cannot start. - Nod's own token is stored under github-token, the account NodRuntime/src/credentials.ts reads; github-copilot never reached the engine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.1.78-beta1's Nod setup shows "This build has no GitHub sign-in configured" on every Mac: the screen only knows GitHub's device flow, and the build carries no GraphCode OAuth client id. Macs already signed in to the Copilot CLI, which NodRuntime's Copilot engine falls back to, were told they could not sign in.
copilot-clipresent (attributes only, no prompt) → signed in, shown as "Using your Copilot CLI sign-in", no Sign outcopilot login, with Check again, instead of a device flow that cannot startgithub-token, the accountNodRuntime/src/credentials.tsreads;github-copilotnever reached the engineNodRuntimeLocatorNot covered: a Mac authenticated only by
COPILOT_GITHUB_TOKEN/GH_TOKEN/GITHUB_TOKENin its shell. The runtime uses those, but the app cannot see shell-only variables.Evidence
RED: NodSetupModelTests.theCopilotCLILoginSignsCopilotIn on origin/main -> compile failure, NodSetupModel has no copilotCLISignInFound and NodCredential.githubCopilot is "github-copilot"
GREEN: xcodebuild test -only-testing NodSetupModelTests + NodCredentialStoreTests -> exit 0, 12 tests passed
REGRESSION: full xcodebuild test -> 2213 tests, only MessageDeliveryTests.aSessionWhoseTaskEndedIsNeverTypedInto fails, identically on main on this Mac; cli and daemon builds exit 0; make check 0 errors; swift-portable exit 0