Repository navigation
[tracer] Screenshots in a .zip, and paths outside a home cut - #48
Merged
Merged
Conversation
ScarletNX's Share Log zip flags each name as UTF-8 (miniz does), and in the worker's C locale libarchive gives a name with an accent (a game's folder) as none, with ARCHIVE_WARN, which ended the walk through the zip there. The worker makes a UTF-8 locale before it shuts itself in, the names are read in it, and an entry with no name is passed by. Signed-off-by: AO55 <AO55@reden-emu.dev>
A player's Share Log zip (report 66) held five screenshots beside its
logs, and Tracer kept the log alone. A .zip's screenshots are now kept
beside its log, under their names, as attached ones are (a PPM as a PNG,
their metadata out, 8 a report); a zip brings them to a report full of
logs, and a file whose bytes are a picture is taken as one whatever its
name says. A limit says what it cut: a file's size ("it is 30.2 MiB, over
the 25 MiB a screenshot may be"), the names past the 8. An approved
report's issue shows its screenshots as the site's pictures.
scripts/test-rule-mutants.py becomes scripts/test-mutants.py, with this
change's mutants beside the rules' (test_tracer --files runs its tests).
Signed-off-by: AO55 <AO55@reden-emu.dev>
Report 58's log showed /mnt/<disk>/<folders>/ where the player keeps games: the homes' ~ covers /home and C:\Users, not a disk mounted elsewhere. A path under /mnt, /media, /run/media, /Volumes, /storage or /sdcard, or on a drive but in its \Users, \Windows and \Program Files, is now ~ and its file's name, its folders and the mount's own name gone. It is cut before the homes' ~, and the next start cuts the logs kept before (facts 7). Signed-off-by: AO55 <AO55@reden-emu.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A player's Share Log zip held five screenshots beside its logs, and Tracer kept the log alone (report 66); report 58's log showed where the player keeps games on a disk mounted under /mnt.
[tracer] A zip's names are read as UTF-8, past one that is none: ScarletNX's Share Log flags each name as UTF-8 (miniz does), and in the worker's C locale libarchive gave a name with an accent as none and ended the walk through the zip there. The worker makes a UTF-8 locale before it shuts itself in, where its files no longer open.[tracer] A zip's screenshots are kept, and a picture is never a log: a .zip's screenshots are kept beside its log as attached ones are (a PPM as a PNG, metadata out, 8 a report), a file whose bytes are a picture is never read as a log, a limit says the size or the names it cut, and an approved report's issue shows its screenshots as the site's pictures.scripts/test-rule-mutants.pybecomesscripts/test-mutants.py, with this change's mutants beside the rules'.[tracer] A path outside a home keeps its file's name alone: a path under /mnt, /media, /run/media, /Volumes, /storage or /sdcard, or on a drive but in its \Users, \Windows and \Program Files, is written as ~ and its file's name; the next start cuts the logs kept before.The issue's pictures are fetched by GitHub's image proxy from the site, which Cloudflare's challenge answers with 403 today.