Improvement/cldsrv 875 integrate shared prettier by benzekrimaha · Pull Request #6124 · scality/cloudserver

benzekrimaha · 2026-03-31T16:19:36Z

bert-e · 2026-03-31T16:19:44Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

claude · 2026-03-31T16:22:43Z

Bug: scripts/format-changed.sh:33 — the grep regex double-escapes the backslash (\\. instead of \.), so the pattern matches a literal backslash before the dot. No filenames contain a backslash, so zero files will ever match and the Prettier check silently passes without checking anything.
- Use a single backslash before the dot in the grep pattern

Review by Claude Code

claude · 2026-03-31T16:25:42Z

scripts/format-changed.sh:33 — double backslash in grep pattern makes the file-extension filter a no-op, so the Prettier check silently passes on every PR without actually checking any files.

Review by Claude Code

claude · 2026-03-31T16:26:37Z

Bug: grep regex never matches any files (scripts/format-changed.sh:29) — Double backslash in single-quoted grep pattern means no file extensions will match, so the Prettier check is a no-op on every PR. Fix: use a single backslash before the dot.
- CI: unnecessary full clone on push builds (.github/workflows/tests.yaml:87) — fetch-depth: 0 applies to all triggers but is only needed for the Prettier step on pull_request events. Consider making it conditional.

Review by Claude Code

bert-e · 2026-03-31T16:26:37Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

claude · 2026-03-31T16:26:42Z

scripts/format-changed.sh:29 — Double-escaped backslash in grep pattern (\\\.) causes file extension matching to fail silently. No files ever match, so the Prettier check is effectively a no-op. Use a single backslash (\.) to match a literal dot.

Review by Claude Code

claude · 2026-03-31T16:34:00Z

--depth=0 is not a valid documented git fetch option (.github/workflows/tests.yaml:98)
- Remove the --depth=0 flag or use a valid positive integer

Review by Claude Code

claude · 2026-03-31T16:44:54Z

Shallow fetch depth may break three-dot diff (.github/workflows/tests.yaml:98): --depth=1 fetches only the base branch tip. The script uses BASE_SHA...HEAD (three-dot), which requires merge-base computation and may fail with insufficient history.
- Increase fetch depth or switch to two-dot diff in the script
Script injection in workflow (.github/workflows/tests.yaml:98): ${{ github.event.pull_request.base.ref }} used directly in run: — pass via env var instead per GitHub Security Lab best practices.
- Use an env: block to pass base.ref and reference $BASE_REF in the command
Silent skip on missing base ref (scripts/format-changed.sh:26): Exits 0 when base ref is unresolvable, silently skipping the prettier check.
- Use ::warning:: annotation so the skip is visible in CI summary

Review by Claude Code

claude · 2026-03-31T16:49:21Z

Adding pull_request trigger alongside existing push trigger causes all CI jobs to run twice for PRs (once per event). Only the Prettier step is gated on event type.
- Restrict push to default branch only, or add a concurrency group to cancel duplicates.
format-changed.sh fetch fallback (line 20) cannot fetch by raw SHA from most remotes; if the base SHA is outside the shallow clone depth, the Prettier check silently skips.
- Use BASE_REF for the fetch fallback instead of stripping origin/ from a SHA.

Review by Claude Code

claude · 2026-03-31T17:09:22Z

LGTM

Review by Claude Code

codecov · 2026-03-31T17:14:49Z

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
8457	4	8453	0

View the top 3 failed test(s) by shortest run time

"before each" hook for "should get a range that spans both parts of an object"::aws-node-sdk range tests aws-node-sdk range test for object put by MPU With v4 signature "before each" hook for "should get a range that spans both parts of an object"

Stack Traces | 5.14s run time

Error uploading part 2: Connection timed out after 5000 ms

"before each" hook for "should retrieve a part copied from an MPU"::GET object With default signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part copied from an MPU"

Stack Traces | 5.53s run time

Connection timed out after 5000 ms

"before each" hook for "should retrieve a part put after part copied from MPU"::GET object With default signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part put after part copied from MPU"

Stack Traces | 5.53s run time

Connection timed out after 5000 ms

View the full list of 2 ❄️ flaky test(s)

"before each" hook for "should retrieve a part that overwrote another part originally copied from an MPU"::GET object With v4 signature With PartNumber field uploadPartCopy overwrite "before each" hook for "should retrieve a part that overwrote another part originally copied from an MPU"

Flake rate in main: 100.00% (Passed 0 times, Failed 19 times)

Stack Traces | 6.42s run time

Connection timed out after 5000 ms

should copy two parts from a source bucket to a different destination bucket and complete the MPU::Object Part Copy With default signature When copy source was put by MPU should copy two parts from a source bucket to a different destination bucket and complete the MPU

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 5s run time

Connection timed out after 5000 ms

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

claude · 2026-04-01T09:59:01Z

package.json reformatted to 4-space indentation will conflict with yarn's native 2-space output when dependencies are added/removed, requiring developers to re-run prettier after every yarn add/remove
- Exclude package.json from prettier via .prettierignore, or document this step in contributing guidelines

Review by Claude Code

claude · 2026-04-01T10:42:48Z

Concurrency group uses pull_request.head.sha which is unique per commit, so cancel-in-progress won't actually cancel previous runs for the same PR. Use pull_request.number instead.

Review by Claude Code

claude · 2026-05-07T08:27:05Z

+        "@smithy/node-http-handler": "^3.0.0",
+        "arsenal": "git+https://github.com/scality/Arsenal#8.3.9",
+        "async": "2.6.4",
+        "bucketclient": "scality/bucketclient#8.2.7",


arsenal was downgraded from 8.4.1 to 8.3.9. If this is intentional (e.g., aligning with a release branch), ignore this. If not, this may introduce regressions — the base branch already had 8.4.1.

— Claude Code

claude · 2026-05-07T08:27:20Z

arsenal dependency was downgraded from 8.4.1 to 8.3.9 — verify this is intentional and not an artifact of the branch base
- If intentional, no action needed; if accidental, restore to 8.4.1
- New lint.yaml uses actions/checkout@v6 and actions/setup-node@v6 while tests.yaml remains on @v4
- Align the versions across workflows for consistency

Review by Claude Code

claude · 2026-05-07T08:35:49Z

Arsenal downgraded from 8.4.1 to 8.3.9 in package.json and yarn.lock. This appears unintentional for a formatting-only PR and could revert fixes/features. The corresponding @scality/hdclient entry was also removed from the lockfile as a side effect.
- Restore arsenal to 8.4.1, or document why the downgrade is needed.

Review by Claude Code

bert-e · 2026-05-07T09:36:06Z

Conflict

There is a conflict between your branch improvement/CLDSRV-875-Integrate-shared-prettier and the
destination branch development/9.3.

Please resolve the conflict on the feature branch (improvement/CLDSRV-875-Integrate-shared-prettier).

git fetch && \
git checkout origin/improvement/CLDSRV-875-Integrate-shared-prettier && \
git merge origin/development/9.3

Resolve merge conflicts and commit

git push origin HEAD:improvement/CLDSRV-875-Integrate-shared-prettier

The following options are set: create_integration_branches

bert-e · 2026-05-07T09:37:47Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.4/improvement/CLDSRV-875-Integrate-shared-prettier with contents from improvement/CLDSRV-875-Integrate-shared-prettier
and development/9.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.4/improvement/CLDSRV-875-Integrate-shared-prettier origin/development/9.4
 git merge origin/improvement/CLDSRV-875-Integrate-shared-prettier
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.4/improvement/CLDSRV-875-Integrate-shared-prettier

The following options are set: create_integration_branches

claude · 2026-05-07T09:40:18Z

LGTM

Review by Claude Code

Issue: CLDSRV-875

claude · 2026-05-07T13:52:59Z

Action version mismatch: lint.yaml uses actions/checkout@v6 / actions/setup-node@v6 while tests.yaml still uses @v4. Align on the same versions to avoid inconsistent CI behavior.

Review by Claude Code

bert-e · 2026-05-07T14:02:51Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

benzekrimaha · 2026-05-07T14:04:33Z

/create_pull_requests

bert-e · 2026-05-07T14:04:46Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-875-Integrate-shared-prettier into
development/9.3
w/9.4/improvement/CLDSRV-875-Integrate-shared-prettier will be merged into development/9.4 (pull request INTEGRATION [PR#6124 > development/9.4] Improvement/cldsrv 875 integrate shared prettier #6165)

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2026-05-07T14:04:47Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2026-05-07T14:55:22Z

/approve

bert-e · 2026-05-07T15:12:21Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Please check the status of the associated issue CLDSRV-875.

Goodbye benzekrimaha.

The following options are set: approve, create_pull_requests, create_integration_branches