feat: raise the SSDP M-SEARCH session cap to 64#52
Merged
Conversation
MAX_SESSIONS bounds the in-flight M-SEARCH sessions_ table globally, across all groups. 32 was conservative; 64 gives more headroom for bursty discovery on busier segments while staying bounded. Make the constant public (like DialProxy's MAX_CONNECTIONS) and have the two cap tests reference it symbolically, so they pin the enforcement independently of the value and a future bump needs no test edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the SSDP M-SEARCH session cap from 32 to 64.
MAX_SESSIONSbounds the in-flight M-SEARCHsessions_table globally (across all SSDP groups); a search past it is dropped before reserving a response port. 32 was conservative — 64 gives more headroom for bursty discovery on busier segments while staying bounded.The constant becomes public (matching
DialProxy::MAX_CONNECTIONS), and the two cap tests (CapDropsSessionsBeyondTheLimit,SessionCapIsGlobalAcrossGroups) now reference it symbolically (MAX_SESSIONS/MAX_SESSIONS + 1). They pin the enforcement independently of the value, so a future bump needs no test edit.Verification