fix: reject an M-SEARCH MX value with trailing garbage#50
Merged
Conversation
ParseMSearchMx checked from_chars's error code but never its end pointer, so "MX: 2abc" quietly parsed as 2. The MX grammar is a bare integer (UDA): require the whole value to be digits, tolerating trailing whitespace like the DIAL framer's Content-Length parse. A malformed value now classifies as invalid — the search still reflects, with the default window and the existing INFO log, matching the missing-MX policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseMSearchMxcheckedfrom_chars's error code but never its end pointer, so"MX: 2abc"quietly parsed as 2. The MX grammar is a bare integer (UDA also has devices silently discard malformed search requests outright): require the whole value to be digits, tolerating trailing whitespace like the DIAL framer's Content-Length parse.Deliberate scope: a malformed value is rejected as a value, not as a message — the search still reflects, with the default window and the existing INFO log. That keeps malformed MX coherent with the existing missing-MX tolerance (the reflector reflects verbatim and lets target devices apply their own spec enforcement).
Tests:
"2abc"/"2 seconds"rejected (fails without the fix),"2 "/"3\t"still parse (whitespace tolerance pinned).Native unit (ASan/UBSan) 849/849 green locally; the full local gate is running in parallel with this PR's CI — I'll flag anything it turns up.