Skip to content

Nautilus#406

Open
eshelDror wants to merge 4 commits into
sblunt:mainfrom
eshelDror:nautilus
Open

Nautilus#406
eshelDror wants to merge 4 commits into
sblunt:mainfrom
eshelDror:nautilus

Conversation

@eshelDror
Copy link
Copy Markdown
Collaborator

Add basic functionality for the nautilus nested sampler https://github.com/johannesulf/nautilus
Add to requirements

@eshelDror eshelDror marked this pull request as ready for review May 27, 2026 17:00
Copy link
Copy Markdown
Owner

@sblunt sblunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Eshel et al! Nice work on this PR. I have two minor modification requests:

  1. I think it would be nice for the NautilusSampler object to inherit from the dynesty-based NestedSampler object so that we don't have the repeated prior transform code. Better yet, we could have a BaseNestedSampler class that both NestedSampler and NautilusSampler classes inherit from.

  2. Rather than using strong-typing, please follow the docstring format of other orbitize! classes/functions. This makes sure that our docs are built correctly (see e.g. https://orbitize.readthedocs.io/en/latest/sampler.html)

@sblunt
Copy link
Copy Markdown
Owner

sblunt commented Jun 1, 2026

Oh actually, one other thought-- in the current main branch, there is a new implementation of multinest, also a nested sampling algorithm. It would be good to merge the current version of main in here and implement the base class for all three nested sampling algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants