Nautilus#406
Conversation
sblunt
left a comment
There was a problem hiding this comment.
Hey Eshel et al! Nice work on this PR. I have two minor modification requests:
-
I think it would be nice for the NautilusSampler object to inherit from the dynesty-based NestedSampler object so that we don't have the repeated prior transform code. Better yet, we could have a BaseNestedSampler class that both NestedSampler and NautilusSampler classes inherit from.
-
Rather than using strong-typing, please follow the docstring format of other orbitize! classes/functions. This makes sure that our docs are built correctly (see e.g. https://orbitize.readthedocs.io/en/latest/sampler.html)
|
Oh actually, one other thought-- in the current main branch, there is a new implementation of multinest, also a nested sampling algorithm. It would be good to merge the current version of main in here and implement the base class for all three nested sampling algorithms. |
Add basic functionality for the nautilus nested sampler https://github.com/johannesulf/nautilus
Add to requirements