Preserve TabM backbone_params in TorchUniversalModel#176
Open
tippered1-debug wants to merge 1 commit into
Open
Preserve TabM backbone_params in TorchUniversalModel#176tippered1-debug wants to merge 1 commit into
tippered1-debug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TabM parameter propagation.
TorchUniversalModelwas overwritingbackbone_paramswhen addingstart_scaling_init_chunks. Because of that, user-provided TabM params likek,d_block,n_blocks,dropout, andarch_typecould be ignored.This PR preserves the existing
backbone_paramsand only addsstart_scaling_init_chunks.It also makes the TabM batch sampler read
kfrombackbone_params, so the sampler uses the same ensemble size as the TabM model.Added tests for preserving
backbone_paramsand reading TabMkcorrectly.Checks run:
.venv/bin/python -m pytest tests/unit/test_automl/test_presets/test_tabularautoml_tabm.py -q -k "preserves_backbone_params or uses_tabm_k" .venv/bin/python -m py_compile lightautoml/text/nn_model.py lightautoml/ml_algo/dl_model.py tests/unit/test_automl/test_presets/test_tabularautoml_tabm.py git diff --check