Repository navigation
Fix DrawOrgChart resizing the target page - #228
Merged
Merged
Conversation
DrawOrgChart renders the chart into a new document, but then resized the page passed as its TargetPage, which does not contain the chart. That shrank the caller's page for no reason (live-verified: an 8.5 x 11 page became 1.51 x 1.51). The chart's own pages are already sized by the render, so the extra resize is removed; the TargetPage now only supplies the application. Adds a regression test that failed before the change. Updates the changelog, test counts, the CLAUDE.md state and priorities, and the Models docs backlog entry. Closes #219 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #219.
Client.Model.DrawOrgChartrendered the chart into a new document and then resized the page passed as itsTargetPage, which does not contain the chart. That shrank the caller's page for no reason (live-verified: an 8.5 x 11 page became 1.51 x 1.51). The chart's own pages are already sized by the render, so the extraResizeToFitContents()is removed. TheTargetPagenow only supplies the application, as the docs already described.Out-VisioApplication -OrgChartgoes through the same method, so it is fixed too.Testing
DrawOrgChart_DrawsInANewDocumentAndLeavesTheTargetPageAlone(VTest.Models). It failed before the fix (page width 8.5 became 1.51) and passes after.VTest(108 tests) is not touched by this change and was not re-run.Also in this PR
NuGet/CHANGELOG.md[Unreleased]: Fixed entry.docs/TESTING.md:VTest.Modelscount 80 -> 81 and a note on the new test.CLAUDE.md: state refreshed; DrawOrgChart resizes the target page but draws the chart in a new document #219 removed from the next-session priorities and the list renumbered.docs/futures/docs.md: the Models docs follow-ups entry now treats DrawOrgChart resizes the target page but draws the chart in a new document #219 as a release-gated docs note.The matching GitBook change is in saveenr/VisioAutomation_GitBook_Docs (see the companion PR); it describes this as an unreleased change after 3.1.0.
Closes #219
🤖 Generated with Claude Code