Skip to content

chore: adopt knip and clean up dead code - #21

Merged
sarthakagrawal927 merged 2 commits into
mainfrom
chore/knip-dead-code-cleanup
Jul 20, 2026
Merged

chore: adopt knip and clean up dead code#21
sarthakagrawal927 merged 2 commits into
mainfrom
chore/knip-dead-code-cleanup

Conversation

@sarthakagrawal927

Copy link
Copy Markdown
Collaborator

Summary

  • Add knip.json with fleet-standard configuration
  • Add knip devDependency and knip/knip:strict scripts
  • Remove unused files, dependencies, and exports identified by knip

Test plan

  • pnpm typecheck passes
  • pnpm knip passes

Generated with Devin

Add knip.json with fleet-standard config, knip devDep and scripts.
Remove unused files, dependencies, and exports identified by knip.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9176bbff53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread extension/src/types.ts
}

export interface ApplyPacket {
interface ApplyPacket {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore exports for shared extension payload types

The extension content and popup scripts still import ApplyPacket, FillResult, ReceiptField, FileAttachment, and related types from ./types (checked extension/src/content.ts and extension/src/popup.ts), but this change makes those interfaces local to the module. Because extension/tsconfig.json includes src/**/*.ts, the extension typecheck/build will fail with missing/non-exported type imports, so the Chrome extension cannot be built until these shared message/result types are exported again or the imports are removed.

Useful? React with 👍 / 👎.

Outer tile is a hard square so browser tabs do not show blank corner padding.
@sarthakagrawal927
sarthakagrawal927 merged commit 287e6a1 into main Jul 20, 2026
7 checks passed
@sarthakagrawal927
sarthakagrawal927 deleted the chore/knip-dead-code-cleanup branch July 20, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant