chore: fix CI — ruff formatting and minio service startup - #6
Merged
Conversation
- Run ruff format on 6 files that would be reformatted (infer.py, ingest_data.py, schemas.py, engine.py, search.py, qdrant_store.py). - Fix ragas-eval minio service: the minio/minio image requires `server /data` as CMD args which GitHub Actions service containers cannot pass via options. Move minio to an explicit `docker run` background step with a health-poll loop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff format --check(infer.py, ingest_data.py, schemas.py, engine.py, search.py, qdrant_store.py)services:container (where CMD args can't be passed) to an explicitdocker runbackground step that runsminio server /data, with a health-poll loopRoot causes fixed
minio/minioimage requiresserver /dataas CMD args to start the server; GitHub Actionsservices.optionsonly passesdocker runflags, not CMD args, so the container started but just printed help and exited unhealthy🤖 Generated with Claude Code