Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/kb/query/graph_route.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ async def maybe_graph_answer(
# Apply ticker filter if intent supplied one (e.g., "themes in NVIDIA filings").
ticker = (intent.filters or {}).get("ticker")
if ticker:
rows = [r for r in rows if (r.get("fields") or {}).get("ticker") == ticker] or rows
rows = [r for r in rows if (r.get("fields") or {}).get("ticker") == ticker]
if not rows:
return None

# Pick a grouping field: prefer `category` (RiskFactor has it on SEC),
# fall back to `subject` / `type` / parent_id, otherwise no grouping.
Expand Down
39 changes: 39 additions & 0 deletions tests/test_graph_route.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
"""Graph route behavior."""

from __future__ import annotations

from kb.query.graph_route import maybe_graph_answer
from kb.query.intent import QueryIntent


async def test_graph_route_returns_none_when_ticker_filters_out_all(monkeypatch) -> None:
async def fake_get_active_schema(domain: str, project: str = "default"):
return {
"spec": {
"entities": [
{"name": "RiskFactor", "fields": [{"name": "ticker"}, {"name": "category"}]}
]
}
}

async def fake_list_entities(*, domain: str, type: str, q, limit: int, project: str):
return [
{
"id": "r1",
"display_name": "Risk",
"identity_key": "risk-1",
"fields": {"ticker": "MSFT", "category": "supply"},
}
]

monkeypatch.setattr("kb.query.graph_route.repo.get_active_schema", fake_get_active_schema)
monkeypatch.setattr("kb.query.graph_route.repo.list_entities", fake_list_entities)

out = await maybe_graph_answer(
intent=QueryIntent(kind="lookup", entity_type="RiskFactor", filters={"ticker": "AAPL"}),
domain="sec",
question="themes in NVIDIA filings",
project="default",
)

assert out is None
Loading