[codex] fix query safety and citation numbering - #1
Merged
Conversation
sarthakagrawal927
force-pushed
the
codex/query-safety-citation-fix
branch
from
June 13, 2026 05:43
8b4ab0f to
951fb04
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sarthakagrawal927
force-pushed
the
codex/query-safety-citation-fix
branch
from
June 13, 2026 05:46
951fb04 to
5203be0
Compare
sarthakagrawal927
marked this pull request as ready for review
June 13, 2026 05:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
None.[n]markers ambiguous and the final citation list inconsistent with what the model saw.Validation
uv run pytest -q tests/test_query_synthesis.py tests/test_duckdb_helpers.pyuv run ruff check src/kb/query/engine.py src/kb/query/structured.py tests/test_query_synthesis.py