chore: simplify providers, workflows, and update ui#122
Merged
sasicodes merged 5 commits intoJul 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Google/Gemini removal
main/models.ts),ProviderKey/ModelProviderIdtypes, auth status, web search provider (search/google.tsdeleted), model picker UI, and the provider settings accordionGeminiIconSub-agent tool rename
subagent_spawntool identifier torun_workflow(verb_noun, matchingcreate_session,list_worktrees, etc.)Provider settings redesign
Update button redesign
AGENTS.md cleanup
Testing
pnpm check(lint, format, desktop typecheck) - cleanpnpm --filter @start/desktop vitest run- 800 tests passingGreptile Summary
This PR drops the Google/Gemini provider entirely, renames the
subagent_spawntool torun_workflow, redesigns the provider-settings and update-button UI, and consolidates duplicated rules inAGENTS.md. All changes are internally consistent — types, allowlists, UI components, search routing, tests, and icons are updated in lock-step.ProviderKey,ModelProviderId,WebSearchProvider, model picker, provider accordion, search routing,GeminiIcon, and all tests are cleaned up together with no leftover references.run_workflowrename: The internal tool identifier is updated everywhere (definition, display logic, tests); user-visible labels remain "sub-agents".Confidence Score: 5/5
Clean, internally consistent changes; the Google removal is exhaustive and the UI redesigns follow existing patterns.
Every Google reference — types, allowlist, search router, icons, UI components, tests — is removed in lock-step. The
run_workflowrename is consistent across definition, detail logic, and tests. The UI changes are additive and isolated to specific components. No dependency version changes were made. Thepnpm checkand 800-test suite passing give confidence nothing regressed.No files require special attention.
Important Files Changed
showReleaseNotescorrectly hides the release-notes segment in thedownloaded(Restart) statesupportsSubscriptionconditional fragment, addressing the previously flagged duplicate guardsearchAnthropicis now type-exhaustive with the updatedWebSearchProviderunionsubagent_spawnstring comparisons replaced via the newisWorkflowToolhelper, which is used six times and is not single-use indirectionGeminiIconremoved;NoteTextIconadded for the release-notes link, following the existingstroke-*kebab-case attribute convention used throughout the fileFlowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[runWebSearch] --> B{searchProvider} B -->|openai| C[searchOpenAi] B -->|anthropic| D[searchAnthropic] B -->|null| E[throw unsupported] B -.->|google - REMOVED| F[searchGoogle - DELETED] G[Update component] --> H{status} H -->|available / downloading| I[Left: action button\nRight: release notes link] H -->|downloaded| J[Plain rounded-full\nRestart button] K[Providers accordion] --> L{supportsSubscription} L -->|true| M[Log in with X button\nor divider\nAPI key input] L -->|false| N[API key input only]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[runWebSearch] --> B{searchProvider} B -->|openai| C[searchOpenAi] B -->|anthropic| D[searchAnthropic] B -->|null| E[throw unsupported] B -.->|google - REMOVED| F[searchGoogle - DELETED] G[Update component] --> H{status} H -->|available / downloading| I[Left: action button\nRight: release notes link] H -->|downloaded| J[Plain rounded-full\nRestart button] K[Providers accordion] --> L{supportsSubscription} L -->|true| M[Log in with X button\nor divider\nAPI key input] L -->|false| N[API key input only]Reviews (2): Last reviewed commit: "chore: centralize run_workflow tool iden..." | Re-trigger Greptile
Context used: