docs: document Sashiko-for-Sashiko local and PR review workflow - #592
Merged
Merged
Conversation
Update README.md and GEMINI.md to describe the two-stage self-review development model for the Sashiko repository: 1. Local Agentic Loop: Developers and coding agents run sashiko review with the sashiko project profile on proposed commits after passing make check-pr, resolving any findings locally before opening or updating a pull request. 2. Upstream GitHub PR Review: Once a pull request is opened or updated, the upstream Sashiko instance posts automated review comments on GitHub. Pull request authors are required to act on every finding by either fixing valid defects and pushing an update, or replying with concrete code evidence explaining why a finding is a false positive and proposing corresponding prompt or workflow improvements. Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
Sashiko review✓ No issues found across 1 commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
README.mdandGEMINI.mdto describe the two-stage Sashiko-for-Sashiko development model:sashiko review --project sashikoon proposed commits after passingmake check-pr, resolving any findings locally before opening or updating a pull request.sashiko.sashiko.dev) posts automated review comments (sashiko-bot) on GitHub. Pull request authors are required to act on every finding by either fixing valid defects and pushing an update, or replying with concrete code evidence explaining why a finding is a false positive and proposing corresponding prompt or workflow improvements.