local_review: avoid nested full-workflow retries in stdio workers

[rgushchin]

In review_single_patch, the worker currently wraps worker.run in a
hardcoded 1..=3 retry loop. While appropriate for standalone local CLI
reviews, daemon-spawned worker processes (using stdio-* providers) are
already retried by the parent Reviewer up to review.max_retries times,
causing transient failures to multiply into up to 9 full-workflow
attempts.

Set the inner attempt limit to 1 for stdio-* providers so retries are
governed solely by the parent Reviewer. Also record a missing or empty
review_inline field when findings are present as an attempt error in
last_error rather than falling through on the final attempt, ensuring
the worker returns an error so the parent Reviewer triggers its retry
loop.

[sashiko-bot]

Sashiko review

Commit 1/1 — 9f07ceea local_review: avoid nested full-workflow retries in stdio workers

• [HIGH] In src/local_review.rs (review_single_patch), reducing max_attempts
  to 1 for stdio workers causes a silent failure when the review_inline field
  is missing. If the attempt limit is reached, the loop falls through and
  returns a successful JSON payload with a null error. Because the worker
  returns success instead of an error on the first failure, the parent daemon
  never triggers its own retry loop. It instead saves the defective findings
  and silently skips sending any notification email.

Full review and stage logs on sashiko.sashiko.dev

[sashiko-bot]

Sashiko review — v2

✓ No issues found across 1 commit.

Full review log on sashiko.sashiko.dev