workflow: bypass custom text validator on recitation fallback - #587
Merged
Merged
Conversation
When a text stage such as report_stage triggers a recitation error from the model provider, RecitationPolicy::FallbackToFreeForm activates recitation_fallback_active and instructs the model not to quote code verbatim. However, StageSession::validate still ran the custom text validator (validate_inline_format), which rejected any response lacking verbatim quoted diff lines starting with the greater-than character and forced the model right back into recitation blocks. Bypass the custom text formatting validator when recitation fallback is active (requiring only non-empty text output), and make the Linux report stage recitation reminder explicitly override the inline template diff quoting instructions. Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
Sashiko review✓ No issues found across 1 commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a text stage such as report_stage triggers a recitation error from
the model provider, RecitationPolicy::FallbackToFreeForm activates
recitation_fallback_active and instructs the model not to quote code
verbatim. However, StageSession::validate still ran the custom text
validator (validate_inline_format), which rejected any response lacking
verbatim quoted diff lines starting with the greater-than character and
forced the model right back into recitation blocks.
Bypass the custom text formatting validator when recitation fallback is
active (requiring only non-empty text output), and make the Linux report
stage recitation reminder explicitly override the inline template diff
quoting instructions.