Conversation
Sashiko review✓ No issues found across 1 commit. |
Member
|
Thanks for the PR! I think it should be optional (e.g. --report-preexisting). Most users in the local mode really just want to validate their change, so likely are not interested in preexisting bugs. |
Contributor
Author
|
Good point, I will add a flag. Thank you, Roman. |
hargar19
force-pushed
the
user/hargar/fix-local-preexisting-output
branch
from
September 29, 2026 17:36
1e684ce to
7f5863c
Compare
The Linux patch workflow routes pre-existing concerns away from patch findings so the daemon can verify them in the standalone bug pipeline. The local review renderer only inspected findings, however, and could print "No issues found." without offering access to preserved concerns. Add --report-preexisting to local reviews. Keep the default text output focused on regressions introduced by the reviewed change, while allowing users to list preserved candidates as pending separate verification. JSON output remains unchanged and continues to carry the concerns array. Document the option and cover both its default-off and enabled behavior. Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
Sashiko review — v2✓ No issues found across 1 commit. |
hargar19
force-pushed
the
user/hargar/fix-local-preexisting-output
branch
from
September 29, 2026 17:44
7f5863c to
3ea73c3
Compare
Sashiko review — v3✓ No issues found across 1 commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux patch workflow routes pre-existing concerns away from patch findings so the daemon can verify them in the standalone bug pipeline. The local review renderer only inspected findings, however, and printed "No issues found." when a review preserved pre-existing concerns.
Read the concerns array when rendering local results. Report that no patch-introduced issues were found and list each candidate as pending separate verification. Keep the existing clean message when neither findings nor concerns are present.
Add regression coverage for selecting the correct clean-result message.
Signed-off-by: Hardik Garg hargar@microsoft.com