Add more physical device info - #35
Open
ALevansSamsung wants to merge 5 commits into
Open
ALevansSamsung wants to merge 5 commits into
ALevansSamsung wants to merge 5 commits into
Conversation
ALevansSamsung
changed the base branch from
main
to
feature/swapchain-surface-id
September 15, 2026 21:49
ALevansSamsung
added this pull request to stack #36
September 15, 2026 21:49
csteinberg-samsung
force-pushed
the
feature/more-physical-device-info
branch
from
September 15, 2026 21:57
f5387f0 to
b1b8b97
Compare
| " enumerateApiEventId INT," | ||
| // VkPhysicalDeviceProperties, filled in later by vkGetPhysicalDeviceProperties[2] - nullable | ||
| // because that call may never be captured. | ||
| " apiVersion INT," |
Collaborator
There was a problem hiding this comment.
I think the reason I had not originally included these is due to the fact that they might not get queried during a capture. I expected the vulkaninfo implementation in sokatoa to drive that part of the information in the UI. I dont think this is problematic though, this is useful for other implementations that might want to get this information from the db if present (particularly for captures starting at frame 1 - untrimmed)
ALevansSamsung
marked this pull request as ready for review
September 17, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more info from Physical Device Properties such as Limits and driver versions