Use vmdk size from .ova files#29
Open
leust wants to merge 1 commit into
Open
Conversation
Since .ova files contain more than just the .vmdk, the size reported by glance is not the size of the actual upload. Since olso.vmware now has a guard against not-finished uploads integrated, we cannot just use the size from glance. Instead, we switch to using the size of the .vmdk as reported by the tar file.
joker-at-work
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since .ova files contain more than just the .vmdk, the size reported by
glance is not the size of the actual upload. Since olso.vmware now has a
guard against not-finished uploads integrated, we cannot just use the
size from glance. Instead, we switch to using the size of the .vmdk as
reported by the tar file.
Ported from sapcc/nova@5d73d02