conductor: Cross-HV resize preflight checks#625
Conversation
grandchild
changed the base branch from
stable/2023.2-m3
to
cross-hv-reqspec-early-commit
grandchild
force-pushed
the
crosshv_resize_detection
branch
2 times, most recently
from
91eb9fa to
41d1d06
Compare
| self.context, self.instance.uuid) | ||
| volume_ids = {bdm.volume_id for bdm in bdms if bdm.volume_id} | ||
| if volume_ids: | ||
| snapshots = volume_api.get_all_snapshots(self.context) |
There was a problem hiding this comment.
This iterates through all the snapshots of a project as far as I can tell. Is there maybe a way to filter for the volume id below at the cinder API level already?
There was a problem hiding this comment.
https://docs.openstack.org/api-ref/block-storage/v3/index.html#volume-snapshots-snapshots
doesn't look like it :/
| self.context, self.instance.uuid) | ||
| volume_ids = {bdm.volume_id for bdm in bdms if bdm.volume_id} | ||
| if volume_ids: | ||
| snapshots = volume_api.get_all_snapshots(self.context) |
There was a problem hiding this comment.
I know it is still specified in the ticket to have this snapshot check. But since we are not doing volume retyping for BFV during the resize (anymore), it's probably not required (anymore).
There was a problem hiding this comment.
hm, right... I'll remove it altogether.
grandchild
force-pushed
the
crosshv_resize_detection
branch
3 times, most recently
from
251f927 to
4116348
Compare
|
Added unit tests. |
grandchild
force-pushed
the
crosshv_resize_detection
branch
from
4116348 to
78d8199
Compare
We allow it only if it's: - a BFV instance, that - is powered on. And only from VMware to CH, not backwards. The image properties are now sanitized and saved, only on vmware->ch hv transition, inside the new _prep_cross_hv_resize() step. Change-Id: I50dedca220e70f51811c0f9b9327ca3ae7ea9e12
grandchild
force-pushed
the
crosshv_resize_detection
branch
from
78d8199 to
72706db
Compare
3 participants
We allow it only if it's:
And only from VMware to CH, not backwards.