[SAP] Remove capabilities dump from scheduler update debug logs#340
Open
hemna wants to merge 1 commit into
Open
[SAP] Remove capabilities dump from scheduler update debug logs#340hemna wants to merge 1 commit into
hemna wants to merge 1 commit into
Conversation
Logging the full capabilities dict on every volume service update causes unnecessary CPU and GC pressure in large regions where many pools are reported. The dict can be 15-50KB for multi-pool backends and is serialized on every capability report cycle. The host/cluster identity is preserved in the log message so update events remain traceable. Capability data is still stored in service_states and accessible via other debug paths. Change-Id: Ie19c0ce8eb4787b98941d2fe412c6b988ff8532d
| else '') | ||
| LOG.debug("Received %(service_name)s service update from %(cluster)s " | ||
| "%(host)s: %(cap)s%(cluster)s", | ||
| "%(host)s%(cluster)s", |
Collaborator
There was a problem hiding this comment.
Why would we duplicate the %(cluster)s in this message?
Author
There was a problem hiding this comment.
the point was to remove the capabilities and leave the rest alone.
Collaborator
There was a problem hiding this comment.
So anything broken we see, we just don't fix, because that's not our current mission. Got it.
Can you please keep the space then, so the duplicate cluster string isn't immediately applied to the host string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging the full capabilities dict on every volume service update causes unnecessary CPU and GC pressure in large regions where many pools are reported. The dict can be 15-50KB for multi-pool backends and is serialized on every capability report cycle.
The host/cluster identity is preserved in the log message so update events remain traceable. Capability data is still stored in service_states and accessible via other debug paths.
Change-Id: Ie19c0ce8eb4787b98941d2fe412c6b988ff8532d