Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ jobs:
- name: Build Chrome extension
run: pnpm extension:build

- name: Build devtools assets package
- name: Build devtools package
run: pnpm devtools:build-pkg

- name: Check committed build output is current
run: |
stale=$(git status --porcelain -- extension/ui packages/ng-devtools-assets/dist)
stale=$(git status --porcelain -- extension/ui)
if [ -n "$stale" ]; then
echo "$stale"
echo "::error::Committed build output is stale. Run 'pnpm extension:build && pnpm devtools:build-pkg' and commit the result."
echo "::error::Committed build output is stale. Run 'pnpm extension:build' and commit the result."
exit 1
fi

Expand Down
4 changes: 2 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ You are an expert in TypeScript, Angular, and scalable web application developme
- **Devtools SPA (hot reload):** `pnpm devtools:dev` → http://localhost:5173 (requires the SSR server running for RPC data)
- **Demo app (SPA, no SSR):** `pnpm start` → http://localhost:4200 (runs `ng serve` with SSR and hot reload; devtools popup + RPC work without a separate server)
- The devtools popup appears on the demo app page; click it to open the inspector panel
- Changes to `app/src/` (devtools SPA) are only visible via `pnpm devtools:dev`; the SSR server serves the npm-published assets
- To publish updated SPA assets: update versions in `packages/ng-devtools/package.json` and `packages/ng-devtools-assets/package.json`, then run `pnpm devtools:publish` (builds and publishes both `ng-devtools` and `ng-devtools-assets` to npm)
- Changes to `app/src/` (devtools SPA) are visible live via `pnpm devtools:dev`; the SSR server serves the SPA built into `packages/ng-devtools/dist/public` (or the npm-published copy when it has not been built), so run `pnpm devtools:build-pkg` to refresh it
Comment thread
coderabbitai[bot] marked this conversation as resolved.
- To publish: update the version in `packages/ng-devtools/package.json`, then run `pnpm devtools:publish` (the package build bundles the SPA)
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pnpm install
```
app/ # Devtools UI SPA (Angular + Vite)
src/app.ts # Root component with tab navigation
src/pages/ # Dashboard, Components, Routes, Signals, Injectors
src/pages/ # Dashboard, Components, Routes, Signals, Injectors, Store, Forms
vite.config.ts # Vite config with Analog Angular plugin
packages/
ng-devtools/ # Publishable npm package
Expand Down Expand Up @@ -86,6 +86,6 @@ pnpm format:check
1. Fork and create a branch from `main`
2. Make your changes
3. Verify `pnpm devtools:build` succeeds
4. If you changed `app/`, run `pnpm extension:build && pnpm devtools:build-pkg` and commit `extension/ui` and `packages/ng-devtools-assets/dist`. CI fails when they are stale
4. If you changed `app/`, run `pnpm extension:build` and commit `extension/ui`. CI fails when it is stale
5. Test with `pnpm devtools:dev`
6. Open a PR against `main`
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"express": "^5.1.0",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"valibot": "^1.5.0",
"zone.js": "^0.16.3"
},
"devDependencies": {
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading