build(deps): update devframe to 1.2.0 - #207
Conversation
devframe 1.2.0 shares an https dev server for the hub WebSocket, localizes dock titles and the hub UI, and always sets defaultChildId so client docks load reliably. Bumps devframe and the @devframes packages to ^1.2.0.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe root, Angular Native example, and ng-devtools package manifests update Devframe dependency ranges to version 1.2.0. ChangesDevframe Dependency Updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other Suggested labels: Merge Risk: ⚪ Minimal · up to No actionable issue is established by the supplied evidence; the dependency update is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changed manifests satisfy the requested version updates in ✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the versions in a row Comment |
|
View your CI Pipeline Execution ↗ for commit e6f08af
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
What and why
Updates
devframeand the@devframes/*packages (agentic, hub, hub-ui, vite) to^1.2.0in the root, the package and the Angular Native example. 1.2.0 shares an https dev server for the hub WebSocket (devframes/devframe#419), localizes dock titles and the hub UI, and always setsdefaultChildIdso client docks load reliably.Our Vite plugin already handles the hub WebSocket upgrade on Vite's own HTTP server (
vite.ts), so the upstream https change doesn't change its behaviour.Closes #204
How it was verified
pnpm commit:checkpnpm format:checkpnpm typecheckpnpm test:devtools(1158) andpnpm test:panelpnpm skills:checkpnpm docs:buildpasses. No docs change, sono-docs: nothing user-facing in this repo changes.pnpm extension:build:extension/uiis unchangednx servewith the Vite plugin, the hub at/__devframes/shows the dock rail and a live panel with no page errorsNotes for reviewers
axe still reports
frame-titleandregionon the hub page. 1.2.0 doesn't fix those; that's #206, waiting on devframes/devframe#425.Summary by CodeRabbit