fix(extension): retry server detection, report refusals and wait for the page id - #195
Draft
erkamyaman wants to merge 1 commit into
Draft
erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…the page id The panel dropped each probe's status, so a 403 from the devtools server looked like no answer, and the only way to try again was a reload. It now lists each probe with its status, says when the server refused the request and why, and has a Try again button. It also read the page id from sessionStorage once and loaded without it, so a slow overlay left the panel on another tab's data. The overlay now exposes its page id and the panel waits up to 5 s for it. Fixes santoshyadavdev#103 Fixes santoshyadavdev#104
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
View your CI Pipeline Execution ↗ for commit c6f8698
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the Chrome extension panel's server detection.
#103: retry, and a 403 is not "no answer"
(404),(403)or(no answer).#104: the panel waits for the inspected tab's page id
window.__ngDevtoolsPageIdonce it claims its id, and removes it on dispose only if it still holds that id.Docs: the Chrome extension getting started and contributing pages (statuses, the refused message, Try again, the page id wait, two FAQ items).
Fixes #103
Fixes #104
Checks
extension-panel-bridge.test.tsandoverlay-dispose.test.ts; all fail with the fix revertedpnpm test:devtools(1072),pnpm test:panel,pnpm typecheck,pnpm format:check,pnpm skills:checkand the docs build passNot checked yet