docs: say the panel is dark only and drop the light scheme checks - #193
Conversation
The contributor docs, the verify skill, the a11y reviewer role and test:axe all asked for a light scheme check, but the panel only has a dark theme, so that check tested the same page twice. They now say the panel is dark only, test:axe runs the dark scheme, and the UI guidelines link the light theme feature in santoshyadavdev#192. Fixes santoshyadavdev#181
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (6)
Comment |
|
View your CI Pipeline Execution ↗ for commit 8ab5f0d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Brings in santoshyadavdev#189, santoshyadavdev#191, santoshyadavdev#193 and santoshyadavdev#194. Keeps the one-path loop paragraph next to the new Routes lab sentence in the router docs, adds the santoshyadavdev#194 upgrade note to the 0.0.6 changelog, and rebuilds extension/ui.
The panel only has a dark theme, but
CONTRIBUTING.md, the development docs, thedevtools-verifyskill, thea11y-reviewerrole andpnpm test:axeall asked for a light color scheme check, which tested the same dark page again. This settles #181 on dark only for now:test:axeruns the dark scheme.docs/contributing/ui-guidelines.mdsays the panel is dark only and links ui: support a light theme in the panel #192, the light theme feature split out of Panel: support a light theme, or drop the light scheme check from the contributor docs #181.Fixes #181
Checks
pnpm test:axe,pnpm format:check,pnpm skills:checkand the docs build pass