-
-
Notifications
You must be signed in to change notification settings - Fork 7
ui: support a light theme in the panel #192
Copy link
Copy link
Open
Labels
P3Relevant but not urgentRelevant but not urgentarea: panelThe devtools panel app (app/)The devtools panel app (app/)featureA feature request or a pull request that adds oneA feature request or a pull request that adds oneneeds triageNot looked at by a maintainer yetNot looked at by a maintainer yet
Description
Activity
Metadata
Metadata
Assignees
Labels
P3Relevant but not urgentRelevant but not urgentarea: panelThe devtools panel app (app/)The devtools panel app (app/)featureA feature request or a pull request that adds oneA feature request or a pull request that adds oneneeds triageNot looked at by a maintainer yetNot looked at by a maintainer yet
The panel is dark only (
app/src/styles/_theme.scsssetscolor-scheme: darkfrom one palette). People who use light browser developer tools get a dark panel in a light window. Split out of #181, which settled on dark only for now and removed the light-scheme checks from the contributor docs.Proposed scope
prefers-color-scheme: light, with adata-themeoverride.extension/devtools.jsto the panel withchrome.devtools.panels.themeName, and update it withsetThemeChangeHandler: https://developer.chrome.com/docs/extensions/reference/api/devtools/panels#property-themeNameextension/panel.html,extension/ui/index.html,app/index.htmlandapp/src/hub-rail-style.ts.scripts/panel-axe.mjs, thedevtools-verifyskill, thea11y-reviewerrole,CONTRIBUTING.mdand the development docs.