fix(a11y): label the hidden datepicker input - #35
Merged
Merged
Conversation
Web:InputWithoutLabelCheck flagged the hidden matInput in the expense dialog. Reuse the existing EXPENSE.SELECT_DATE translation as its accessible name, matching the button next to it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the SonarCloud security triage (T2). Fixes the one open code bug; the vulnerability backlog was triaged separately in SonarCloud (false positives / accepted with justification, follow-up in #34).
Web:InputWithoutLabelCheck: the hidden
matInputin the expense dialog had no accessible name. Reuse the existingEXPENSE.SELECT_DATEtranslation, matching the button next to it.