feat(budgets): inherit the previous month's budget and backfill legacy allocations - #23
Merged
Merged
Conversation
…legacy allocations A budget set before recurring budgets existed stayed as a single month's snapshot, so the next month opened with nothing: a full September left October with zero allocations. - Migration 20261001185217_BackfillBudgetDefaults (SQL in BudgetDefaultsBackfill) turns the latest allocation of each category into a budget_defaults row effective from that month, so the following month inherits it. It is idempotent and never invents a budget for an earlier month. - IBudgetService.PromoteMonthToDefaultsAsync and the budget screen's "Aplicar todos los meses" button turn the current month's overrides into the recurring default, keeping an existing default's effective_from and leaving an override whose default starts later. - Replace the "a later month does not inherit" test with the inheritance contract (BudgetInheritanceTests); the per-month snapshot guarantee stays. - Correct TECHNICAL-DESIGN.md, gotchas.md and HANDOFF.md, which still described the retired "copy last month" button.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public async Task Promoting_a_month_without_overrides_promotes_nothing() | ||
| { | ||
| _budgets.FindByPeriodAsync(UserId, September, Arg.Any<CancellationToken>()) | ||
| .Returns((MonthlyBudget?)null); |
|
|
||
| // October has no row of its own: the budget set in September is what has to reach it. | ||
| _budgets.FindByPeriodAsync(UserId, october, Arg.Any<CancellationToken>()) | ||
| .Returns((MonthlyBudget?)null); |
A new migration's Up line is applied by the DatabaseFixture before coverage is attributed to it, so it is always reported at 0 %: the new-code coverage gate failed at 75 % on a single migration line. Migrations are scaffolding whose effect the integration tests prove, so exclude them (and the generated Designer files) from coverage. This keeps every future migration PR from hitting the same gate.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A month with no budget of its own now inherits the previous one through its recurring defaults, and a one-off migration repairs the users whose allocations predate recurring budgets.
20261001185217_BackfillBudgetDefaults(SQL inBudgetDefaultsBackfill) turns the latest allocation of each category into abudget_defaultsrow effective from that month, so the following month inherits it. Idempotent (ON CONFLICT DO NOTHING) and it never invents a budget for an earlier month.IBudgetService.PromoteMonthToDefaultsAsyncand the budget screen's "🔁 Aplicar todos los meses" button turn the current month's overrides into the recurring default, keeping an existing default'seffective_fromand leaving an override whose default starts later.BudgetInheritanceTestsproves the inheritance end to end against PostgreSQL.TECHNICAL-DESIGN.md§5, items 7/14 and the phase table,gotchas.md,HANDOFF.md.Why
Reported after the October rollover: the summary showed no budget and "Todavía no hay asignaciones para este mes", while September was fine. The recurring budget only carries if the assignment was stored as a
budget_defaultsrow; the migration that added it never backfilled existing months, and the "copy previous month" button had been retired, so nothing transferred.How to test
dotnet build MyBudget.sln— 0 warningsdotnet test MyBudget.sln— 848 testsdotnet format MyBudget.sln --verify-no-changesOn a real database: back up, then
--migrate(the migrator container applies the backfill). Open the next month's summary and budget screen — they should be funded; the backfill is idempotent and only inserts.Checklist
long) and dates are calendar dates where relevant..envvalues are committed.AGENTS.md,docs/) updated if behavior or conventions changed.