Repository navigation
test(integration): unique client IPs for rate-limit tests - #77
Merged
Merged
Conversation
RateLimitIntegrationTests picked `203.0.113.{1..253}` at random while
AuthorizationIntegrationTests pinned `203.0.113.250`. When the random draw hit
250 the two shared a limiter partition, so the rate-limit test started with
part of its budget spent and failed intermittently (observed: 6/10 requests
already 429). Replace both with a sequence-based helper that hands out a unique
IP per call, so partitions can never collide.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RateLimitIntegrationTestschose203.0.113.{1..253}at random;AuthorizationIntegrationTestspinned203.0.113.250. When the random draw landed on 250 the two shared a per-IP limiter partition, so the rate-limit test began with part of its budget spent and failed intermittently — observed on the release PR #72: 6 of the first 10 requests were already429.Fix
New
TestClientIps.Next()(a thread-safe counter in the198.18.0.0/15benchmarking range) hands out a unique IP per call. Both tests use it, so partitions can never collide. Verified locally:RateLimitIntegrationTests+AuthorizationIntegrationTestspass (6/6).This is a test-only, deterministic fix; no production code changed.