Repository navigation
feat(i18n): translate the motorcycle flow (3.6) - #76
Merged
Merged
Conversation
Third i18n surface: the motorcycle flow. Moves the strings of the dashboard shell banner, home, motorcycle card, add/edit form, summary and log-record page into the dictionaries, including the confirm/success/error dialogs. Also widens the `t()` params to `unknown` (templates pass pipe results that are typed `string | null`), stringified at interpolation time. Remaining (final PR): maintenance page, save/follow maintenance, statistics, profile and the legal/help long-form text.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Third i18n surface: the motorcycle flow. Moves into the dictionaries:
Also widens
t()params tounknown(templates pass pipe results typedstring | null, e.g. the date/currency pipes), stringified at interpolation.Verification
format:check+ lint clean; AOT build passes.Remaining (final PR)
Maintenance page, save/follow maintenance, statistics, profile + the legal/help long-form text.
docs/specs/i18n.mdtracks it.