feat(driver): register deterministic static inputs - #714
Merged
Conversation
sanohiro
marked this pull request as ready for review
August 6, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review closure
The host-native review was run against the exact final candidate lineage. Findings were closed in coherent fixes covering permitted-driver metadata coverage, symlink containment, complete nested metadata validation, bounded file and inline reads, canonical escape forms, NUL-bearing identities, duplicate descriptor IDs, and lexical defining-module path resolution.
Constructor recognition and descriptor placement remain deferred to the next L5 capability; this PR consumes already-resolved descriptor identities only.
Verification
scripts/cargo.sh check -p align_driver --libscripts/cargo.sh clippy -p align_driver --lib -- -D warningsscripts/cargo.sh test -p align_driver --lib static_inputs(17 passed)scripts/cargo.sh test -p align_driver --test cache_codegen json_scan_copy_row_codegen_key_identity_owner(1 passed)scripts/pre-pr.shwith host-native review and--findings-fixedattestation