feat: add explicit region materialization - #712
Merged
Conversation
sanohiro
marked this pull request as ready for review
August 6, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clone_in(region)materializationarray_builder<T>support for recursivelyRegionPlainvalues across whole-program and per-unit compilationWhy this capability is one PR
The producer and consumer form one strict ownership/ABI chain: region capabilities, materialization, aggregate builder descriptors, interface serialization, LLVM layout, and runtime allocation are not independently useful dormant seams. Keeping them together avoids duplicated cross-stage proofs and tests while leaving one mergeable end-to-end capability.
Review fixes
The bounded full-diff review found four issues, all closed in
f5cbd414:clone_inlengths above the targetisize::MAXValidation
scripts/pre-pr.shon final SHAf5cbd414with the preceding review findings recorded as fixedscripts/test-pr.shscripts/cargo.sh clippy --workspace --lib --bins --locked -- -D warningsalign_driverfb_region: 36 passedalign_semaunit suite: 207 passedalign_runtimeregion-array-builder owners: 4 passed