Skip to content

feat: add package-defined native resources - #711

Merged
sanohiro merged 2 commits into
mainfrom
agent/pkg-db-native-resources
Aug 5, 2026
Merged

feat: add package-defined native resources#711
sanohiro merged 2 commits into
mainfrom
agent/pkg-db-native-resources

Conversation

@sanohiro

@sanohiro sanohiro commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • add package-defined opaque native resources with producer-owned Drop thunks and pointer ABI
  • enforce construction privilege, exact Move/Drop cleanup, resource-reference generations, dependent-resource provenance, and checked native views
  • serialize and validate nominal resource identity for whole-program and per-unit compilation
  • close resource tuple ownership/provenance and declaration-order-independent generic mangling found during review

Verification

  • scripts/pre-pr.sh --base origin/main --reviewer codex-host --review-log ... --findings-fixed --owner-test resource-ownership -- scripts/cargo.sh test -p align_driver --test resource_ownership
  • resource ownership owner suite: 19 passed
  • pre-PR workspace library tests and Clippy: passed

Review

The host-native full-diff review plus its scoped continuation found two P2 issues: local-id-based resource generic mangling and missing tuple producer/HIR-boundary closure. Both were fixed in e3d670d7, with dedicated nominal-identity and whole/per-unit runtime regressions.

@sanohiro
sanohiro marked this pull request as ready for review August 5, 2026 20:29
@sanohiro
sanohiro merged commit c8821c4 into main Aug 5, 2026
5 checks passed
@sanohiro
sanohiro deleted the agent/pkg-db-native-resources branch August 5, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant